Skip to content

implicit | using - #147

Closed
skytteren wants to merge 8 commits into
typr-dev:mainfrom
skytteren:implicitOrUsing
Closed

implicit | using#147
skytteren wants to merge 8 commits into
typr-dev:mainfrom
skytteren:implicitOrUsing

Conversation

@skytteren

Copy link
Copy Markdown
Collaborator

Suppoert using in scala 3 to get rid of warnings.

@skytteren
skytteren requested a review from oyvindberg June 26, 2025 06:39
@skytteren
skytteren marked this pull request as draft June 26, 2025 12:44
@skytteren
skytteren marked this pull request as ready for review June 27, 2025 08:19
@skytteren

Copy link
Copy Markdown
Collaborator Author

The last commit was a bit on the large side.

There is one caveat when using the generated code in the project where typo is applied. A couple of places I had to change from:

import <org>.generated.*

to

import <org>.generated.{*, given}

@skytteren

Copy link
Copy Markdown
Collaborator Author

Should I add the generated .bleep-files? 🤔

@oyvindberg

Copy link
Copy Markdown
Collaborator

Thank you for the contribution. However, given our previous working relationship, I prefer not to collaborate directly on this project.

I'm happy to continue supporting your client as they're a public sector organization, and I'm committed to maintaining this open source project for the community's benefit.

I'd suggest having one of their internal developers submit this change instead, and I'll be glad to review and merge it through that channel.

@oyvindberg oyvindberg closed this Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants