implicit | using - #147
Closed
skytteren wants to merge 8 commits into
Closed
Conversation
skytteren
marked this pull request as draft
June 26, 2025 12:44
skytteren
marked this pull request as ready for review
June 27, 2025 08:19
Collaborator
Author
|
The last commit was a bit on the large side. There is one caveat when using the generated code in the project where typo is applied. A couple of places I had to change from:
to
|
Collaborator
Author
|
Should I add the generated |
Collaborator
|
Thank you for the contribution. However, given our previous working relationship, I prefer not to collaborate directly on this project. I'm happy to continue supporting your client as they're a public sector organization, and I'm committed to maintaining this open source project for the community's benefit. I'd suggest having one of their internal developers submit this change instead, and I'll be glad to review and merge it through that channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppoert
usingin scala 3 to get rid of warnings.