Always report timers/events when worker unparked#4227
Merged
Conversation
Member
Author
|
There's possibly a bigger discussion here, which is whether the fact that polling systems schedule tasks on a worker's local queue while the worker is parked violates some invariant of our runtime 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4225.
A parked worker may wake up for various reasons:
Due to race conditions, a worker may actually wake up for multiple reasons simultaneously. Thus, it should always check first if there are expired timers or polling events, so it can transition to handling those, before considering other cases.
In #4225, we were able to detect this bug because the WSTP had only one worker.