Fix MapRef.fromSeqRefs vulnerability#4208
Merged
djspiewak merged 10 commits intoDec 21, 2024
Merged
Conversation
Contributor
Author
|
Maybe I should leave the old method as |
Member
I think this will definitely be required for compatibility. Speaking of which, why didn't mima flag this? |
Member
It's actually not required for binary-compatibility, because So it's really just a matter of source-compatibility. |
Member
|
Oh, I didn't realize that. I'm totally cool with murdering source compat in 3.6 for something like this, so let's skip the deprecation. |
armanbilge
reviewed
Dec 20, 2024
armanbilge
reviewed
Dec 20, 2024
armanbilge
reviewed
Dec 20, 2024
armanbilge
reviewed
Dec 20, 2024
armanbilge
reviewed
Dec 20, 2024
iRevive
reviewed
Dec 21, 2024
Co-authored-by: Maksym Ochenashko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just fix
fromSeqRefsconstructor ofMapRef. There it was possible to call this method with an empty list of shards, which resulted in a divide by zero exception. Now you can call it with nonempty sequence of shards only. That constructor is only used in two other constructors in the code base. So it no needs to fix some tests or docs, I think.