Make joinWithNever attempting self cancelling#4131
Closed
lenguyenthanh wants to merge 2 commits into
Closed
Conversation
Align the implementation with Spawn docs. Close typelevel#4093.
joinWithNever attempting self cancelling
Member
|
So the concern I have with this is that there's a lot of call-sites which kind of implicitly assume it isn't self-canceling. This is a pretty significant semantic to change. The inconsistency with the docs was actually reported back before 3.0.0 went final, and we decided that the mistaken semantic (the one presently in HEAD) was more expected, but we never went back and fixed the docs. It think it might be better to fix the docs to match the semantic, rather than changing something like this which can have really far-reaching consequences. |
Member
|
See also a similar confusion with |
Member
Author
|
that makes sense. I'll submit another pr for updating the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4093 by attempting self-cancel before
F.never