Skip to content

Improve debugging #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swizec wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve debugging #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1ed1a
Enable access to full request/response body
Swizec Oct 30, 2015
969feed
Typo fix
Swizec Oct 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/shift_planning/api_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
module ShiftPlanning
class ApiError < Exception
attr_accessor :message
attr_accessor :request_body
attr_accessor :response_body

def initialize(response)
def initialize(response, request_body, response_body)
@message = message_for_status(response["status"])
@request_body = request_body
@response_body = response_body
end

def message_for_status(status)
Expand Down
2 changes: 1 addition & 1 deletion lib/shift_planning/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def request(method, api_module, request)
})
response = HTTP.with(@headers).post(@url, body)
result = JSON.parse(response)
raise ApiError.new(result) if @strict && is_error_response?(result)
raise ApiError.new(result, body, response) if @strict && is_error_response?(result)
result
end

Expand Down