[desktop] update appimage to use type 2 runtime - #10841
Open
ganthern wants to merge 1 commit into
Open
Conversation
the old one started to break on some linux distros fix #10784
charlag
reviewed
May 21, 2026
| "commander": "14.0.0", | ||
| "json5": "^2.2.1", | ||
| "electron-builder": "26.7.0", | ||
| "electron-builder": "26.8.1", |
Contributor
There was a problem hiding this comment.
we need to do the review for this version then
Contributor
There was a problem hiding this comment.
their churn does nothing for us, for the most part
There was a problem hiding this comment.
I once again accidentally clicked on the dreaded 'click to update' popup and had to download the newest version to patch it up using my script. Could this be merged?
From what I saw the breaking version of the builder for Electron is 27.y.z, not 26.y.z.
Upgrading from v26? v27 is a major release with breaking changes (native ESM, Node >=22.12, and removed deprecated APIs). Read the breaking changes before upgrading:...
Edit: Nevermind, I can see this PR: #11247
|
Is there any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the old one started to break on some linux distros
fix #10784
this seems enough, running it with
--appimage-versionreports the type 2 runtime.