Put UrlSession in iosNotification handeling to background - #10734
Open
tuta-sudipg wants to merge 1 commit into
Open
Put UrlSession in iosNotification handeling to background#10734tuta-sudipg wants to merge 1 commit into
tuta-sudipg wants to merge 1 commit into
Conversation
charlag
reviewed
Apr 28, 2026
|
|
||
| return urlSession | ||
| public func makeUrlSession() throws -> URLSession { | ||
| let backgroundSessionId = if let bundleId = Bundle.main.bundleIdentifier { |
Contributor
There was a problem hiding this comment.
Does it make sense to just have a separate function for backgroundUrlSesion()?
Clever hack though
Contributor
Author
There was a problem hiding this comment.
Yep. we definitely don't want to change how widget behave. Thanks
tutao-mac
force-pushed
the
ios-notif-no-action
branch
from
April 28, 2026 12:09
09268f0 to
8ad9ab9
Compare
Notification action in ios is not 100% reliable. Sometimes, the action is only applied when the app is in foreground. We suspect it might be because the request we make is not in background tho we could not reproduce it locally. We intend to test in testflight with these changes Co-authored-by: nif <[email protected]>
tuta-sudipg
force-pushed
the
ios-notif-no-action
branch
from
April 28, 2026 12:14
8ad9ab9 to
5c40c7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification action in ios is not 100% relaible. Sometimes, the action is only applied when the app is in foreground.
We suspect it might be because the request we make is not in background tho we could not reproduce it locally.
We intend to test in testflight with these changes