Feat/deterministic npm installs #175
+59
−59
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,5 +16,5 @@ jobs: | |
| with: | ||
| node-version: 24 | ||
|
|
||
| - run: npm ci | ||
| - run: npm test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,82 +29,82 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@types/babel__core": "7.1.2", | ||
| "@types/babel__generator": "7.6.2", | ||
| "@types/babel__template": "7.0.3", | ||
| "@types/babel__traverse": "7.0.15", | ||
| "@types/chalk": "2.2.0", | ||
| "@types/estree": "0.0.44", | ||
| "@types/jest": "30.0.0", | ||
| "@types/koa": "2.0.49", | ||
| "@types/koa-router": "7.0.42", | ||
| "@types/mkdirp": "0.5.2", | ||
| "@types/node": "20.19.40", | ||
| "@types/node-fetch": "1.6.9", | ||
| "@types/ora": "1.3.1", | ||
| "@types/readline-sync": "1.4.3", | ||
| "@types/serialize-javascript": "1.5.0", | ||
| "@types/tmp": "0.0.33", | ||
| "@types/walk": "2.3.0", | ||
| "@types/yargs": "17.0.35", | ||
| "babel-core": "7.0.0-bridge.0", | ||
| "babel-plugin-react-compiler": "19.1.0-rc.2", | ||
| "husky": "0.14.3", | ||
| "jest": "30.4.2", | ||
| "lint-staged": "17.0.4", | ||
| "prettier": "1.19.1", | ||
| "ts-jest": "29.4.9", | ||
| "ts-node": "10.9.2", | ||
| "typescript": "5.5.4" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/core": "7.29.0", | ||
| "@babel/generator": "7.29.1", | ||
| "@babel/plugin-proposal-decorators": "7.29.0", | ||
| "@babel/plugin-proposal-export-default-from": "7.27.1", | ||
| "@babel/preset-env": "7.29.5", | ||
| "@babel/preset-flow": "7.27.1", | ||
| "@babel/preset-react": "7.28.5", | ||
| "@babel/preset-typescript": "7.28.5", | ||
| "@babel/template": "7.28.6", | ||
| "babel-plugin-ttag": "1.8.16", | ||
| "chalk": "2.4.2", | ||
| "cross-spawn": "7.0.6", | ||
| "estree-walker": "2.0.1", | ||
| "gettext-parser": "6.0.0", | ||
|
Comment on lines
+60
to
+73
Contributor
There was a problem hiding this comment. Pinning regular dependencies doesn't look right to me.
Contributor
Author
There was a problem hiding this comment. The pinning helps reduce supply-chain attacks that use the npm version bumping when running With the |
||
| "glob": "13.0.0", | ||
| "hunspell-spellchecker": "1.0.2", | ||
| "ignore": "5.1.8", | ||
| "is-glob": "4.0.3", | ||
| "koa": "2.16.4", | ||
| "koa-body": "7.0.1", | ||
| "koa-router": "14.0.0", | ||
| "mkdirp": "0.5.5", | ||
| "node-fetch": "2.7.0", | ||
| "open": "6.4.0", | ||
| "ora": "1.3.0", | ||
| "plural-forms": "0.5.3", | ||
| "readline-sync": "1.4.9", | ||
|
aperkaz marked this conversation as resolved.
|
||
| "serialize-javascript": "7.0.5", | ||
| "svelte": "5.55.5", | ||
| "tmp": "0.2.5", | ||
| "vue-sfc-parser": "0.1.2", | ||
| "walk": "2.3.9", | ||
| "yargs": "16.2.0" | ||
| }, | ||
| "overrides": { | ||
| "@babel/runtime": "7.29.2", | ||
| "ajv": "6.15.0", | ||
| "brace-expansion": "1.1.14", | ||
| "js-yaml": "3.14.2", | ||
| "yaml": "1.10.3" | ||
| }, | ||
| "jest": { | ||
| "snapshotFormat": { | ||
| "escapeString": true, | ||
| "printBasicPrototype": true | ||
| }, | ||
| "transform": { | ||
| ".+\\.tsx?$": "ts-jest" | ||
|
aperkaz marked this conversation as resolved.
|
||
| }, | ||
| "testRegex": "(/tests/.*|(\\.|/)(test|spec))\\.(tsx?)$", | ||
| "testPathIgnorePatterns": [ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are dev dep dumps really needed? why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reason as #175 (comment) 🙂