Update DD stage names to match MHCT#344
Merged
Merged
Conversation
Contributor
Author
|
This one should go first: #343 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Draconic Depths “Cavern” phase/stage naming to align with MHCT conventions, and adjusts the associated population setup/data to match the new naming.
Changes:
- Renamed Draconic Depths cavern stage labels from
Cavern - …toCavern: …in bookmarklet sublocation logic. - Updated the Draconic Depths POP JS generator to emit the new
Cavern:stage names and reorganized cave mouse lists intostandardvscaves. - Regenerated the Draconic Depths POP CSV output with the updated phase names (and updated AR/sample figures).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bookmarklet/bm-setup-fields.js | Updates Draconic Depths cavern sublocation string format to Cavern: …. |
| src/bookmarklet/bm-cre.js | Mirrors the same Draconic Depths cavern sublocation string update. |
| data/pop-js/draconic-depths.js | Updates generated stage names to Cavern: … and refactors cave mice data structure used for series generation. |
| data/pop-csv/draconic-depths.csv | Updates “Phase” values to Cavern: … and refreshes the exported population rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2
to
+10
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","14.24%","Colonel Crisp",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","14.09%","Noxio Sludgewell",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","13.99%","Dreck Grimehaven",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","13.99%","Blizzara Winterosa",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","13.89%","Torchbearer Tinderhelm",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","13.80%","Iciclesius the Defender",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","6.04%","Squire Sizzleton",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","5.03%","Frostnip Icebound",143931 | ||
| "Draconic Depths","Crucible Forge","Gouda/Brie","-","4.93%","Goopus Dredgemore",143931 |
There was a problem hiding this comment.
This CSV update changes not only the Draconic Depths stage names ("Cavern - …" → "Cavern: …") but also many attraction rates and sample sizes across multiple phases. If the intent of this PR is only to align stage names with MHCT, consider limiting this file to a pure rename (or splitting the data refresh into a separate PR) so reviewers can validate the behavioral/data impact independently.
AardWolf
approved these changes
Apr 2, 2026
Copilot AI
added a commit
to hymccord/MH-Tools
that referenced
this pull request
Apr 3, 2026
…ion data Agent-Logs-Url: https://github.com/hymccord/MH-Tools/sessions/c2bc54ef-c208-4244-9548-92c50c10039d Co-authored-by: hymccord <[email protected]>
hymccord
force-pushed
the
feat/update-dd-stages
branch
from
e795fb4 to
76cd259
Compare
AardWolf
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for DD stage rename