various fixes - also cperl

[rurban]

fix wrong t/50reentrant_goto_sigsegv.t

wrong test count.
wrong name check. install_accessor_with_shim installs a package prefix.

XS: replace op_spare with op_typechecked

in cperl. cperl has no spare bit. we can use that one.
the called function is also enterxssub, the faster XS variant,
not entersub.

fix todo_skip syntax in t/50reentrant_goto_sigsegv.t

fails hard in cperl

[chocolateboy]

I wasn't aware of cperl. Very interesting!

Minor nit: I think I'd use:

OP_SPARE(op)

rather than:

op->OP_SPARE

I don't think I've seen the latter style used before.

the called function is also enterxssub, the faster XS variant,
not entersub

What happens if the sub is redefined from an XSUB to a regular sub? Does OP_ENTERXSSUB handle that?

[rurban]

On Dec 11, 2016, at 7:24 PM, chocolateboy ***@***.***> wrote: I wasn't aware of cperl. Very interesting! Minor nit: I think I'd use: OP_SPARE(op) rather than:

Agreed. Will change.

op->OP_SPARE I don't think I've seen the latter style used before. the called function is also enterxssub, the faster XS variant, not entersub What happens if the sub is redefined from an XSUB to a regular sub? Does OP_ENTERXSSUB handle that?

yes. they will fallback to each other dynamically. but not in this case interestingly. haven’t stepped through it yet.

[rurban]

Now only 2 commits

[rurban]

BTW: I didn't see ribasushi's PR #2. His looks better. Just take my 1st XS commit then.

[chocolateboy]

His looks better.

Thanks. I've merged it.

[chocolateboy]

haven’t stepped through it yet.

Did you get a chance to look into this?

Just take my 1st XS commit then.

Has this been rebased against #2? If not, please make a seperate PR.

[rurban]

My latest fix is in my distroprefs. rurban/distroprefs@0863fd9