Add support for lazy builders - #14
Open
tobyink wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for lazy builders:
When the lazy getter is called, if the hash key does not exist, a method called "build$slot" will be called to return a default value. This will be stored in the hash and then the getter will continue as normal.
Also
lazy_accessorsis supported, including support forchained => 1.I think this patch could be very helpful for accelerating Moo-based code which tries to use Class::XSAccessor when possible, but currently cannot for any lazy-built attributes.
Dancer2 in particular makes heavy use of lazy-built attributes, so this patch has the potential to eventually speed up Dancer2-based websites.