Centralize Hover Detection and Improve Line Interaction Precision - #105
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShiboSoftwareDev
approved these changes
Mar 26, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, hovering over traces is unreliable unless the user zooms in significantly. Thin lines and small segments are especially hard to interact with, leading to missed hovers and inconsistent behavior.
Fix
This change replaces the existing hover model with a distance-based hit detection approach driven by a global mouse position:
Computes distance from cursor to line segments instead of relying on bounding boxes
Introduces a dynamic hover radius based on stroke width
Centralizes mouse tracking instead of per-element event handlers
Before
Screen.Recording.2026-03-26.at.6.52.29.PM.mov
After
Screen.Recording.2026-03-26.at.6.51.23.PM.mov