feat(stampboard): support offset side rows and inner SMT grids - #753
Closed
techmannih wants to merge 1 commit into
Closed
feat(stampboard): support offset side rows and inner SMT grids#753techmannih wants to merge 1 commit into
techmannih wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
stampboardfootprint generator to support footprints containing offset side rows and an internal SMT pad grid.Changes
sideyfor a shared Y offset on the left and right pad rows.innergridto define the internal SMT pad grid dimensions.innerpfor the internal grid pitch.innerpwandinnerphfor internal pad dimensions.innerxandinneryfor the internal grid center position.All new parameters are opt-in, so existing
stampboardfootprints remain unchanged.Motivation
JLCPCB part
C2913202(ESP32-S3-WROOM-1-N16R8) contains:The existing
stampboardgenerator could represent the perimeter layout, but it could not shift the side rows or generate the internal SMT grid.Because of this, the current automatic discovery selected an incorrect
qfn49footprint with very low copper overlap.C2913202 Benchmark
The benchmark used the exact
C2913202footprint fetched from EasyEDA and compared it usingfast-footprint-compare.Results
qfn49fallbackstampboardgeometryImprovement: +96.3112 percentage points
Copper IoU: