repro: solder jumper bridge trace endpoint lands outside pad boundary (FP precision) - #752
Closed
itisrohit wants to merge 6 commits into
Closed
repro: solder jumper bridge trace endpoint lands outside pad boundary (FP precision)#752itisrohit wants to merge 6 commits into
itisrohit wants to merge 6 commits into
Conversation
Author
|
This repro belongs in @tscircuit/core or @tscircuit/checks — the footprinter geometry is correct. The bug is isPointInPad missing an epsilon tolerance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/fn/solderjumper.ts:56-57computes bridge trace endpoints atpadWidth / 2from pad center (exactly on the pad edge). With non-exact IEEE 754 values likepw=0.6604, the compound FP error pushes the endpoint ~5.55e-17mm outside the pad. Downstream DRC (isPointInPad) then reports a false "disconnected endpoint" error.