Skip to content

add diode fab polarity symbols #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techmannih wants to merge 9 commits into
base: main
Choose a base branch
from
Open

add diode fab polarity symbols #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
040f842
add diode fab polarity symbols
techmannih Jul 3, 2026
07e8cc9
update
techmannih Jul 3, 2026
8d4e58e
update
techmannih Jul 3, 2026
93ee7dd
update
techmannih Jul 3, 2026
15faeb3
up
techmannih Jul 3, 2026
f889a18
up
techmannih Jul 3, 2026
f9eb67e
up
techmannih Jul 3, 2026
e4e8d29
up
techmannih Jul 3, 2026
3f71e87
up
techmannih Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"schematic-symbols": "^0.0.224",
"transformation-matrix": "^2.16.1",
"ts-node": "^10.9.2",
"tsup": "^8.0.2",
"typescript": "^5.4.5"
Expand Down
15 changes: 15 additions & 0 deletions src/fn/melf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,

@seveibar seveibar Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? remove

} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const melf_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const melf = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = melf_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.wideThickStroke,

@seveibar seveibar Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline this object in each location- do not create an unnecessarily cyclic dependency (we never use this pattern where you have a referenced dict inside a common utility- a common utility SHOULD NOT CONTAIN specific references)

})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const melf = (

return {
circuitJson: melfWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/micromelf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const micromelf_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const micromelf = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = micromelf_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.micromelfCompact,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const micromelf = (

return {
circuitJson: microMelfWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/minimelf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const minimelf_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const minimelf = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = minimelf_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.wide,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const minimelf = (

return {
circuitJson: miniMelfWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/sma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const sma_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const sma = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = sma_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.smaLike,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const sma = (

return {
circuitJson: smaWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/smb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const smb_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const smb = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = smb_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.smaLike,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const smb = (

return {
circuitJson: smbWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/smbf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const smbf_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const smbf = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = smbf_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.wide,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const smbf = (

return {
circuitJson: smbfWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/smc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const smc_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const smc = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = smc_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.wideThickStroke,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(0, 3, 0.3)

Expand Down Expand Up @@ -67,6 +81,7 @@ export const smc = (

return {
circuitJson: smcWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/smf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const smf_def = base_def.extend({
Expand All @@ -24,6 +28,16 @@ export const smf = (
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = smf_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.smf,
})

// Define silkscreen reference text
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
Expand Down Expand Up @@ -71,6 +85,7 @@ export const smf = (

return {
circuitJson: smfWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/sod110.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const sod_def = base_def.extend({
Expand All @@ -23,6 +27,16 @@ export const sod110 = (
raw_params: z.input<typeof sod_def>,
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = sod_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.sod123Wide,
})
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
length.parse(parameters.h) / 2 + 0.5,
Expand Down Expand Up @@ -69,6 +83,7 @@ export const sod110 = (

return {
circuitJson: sodWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenLine as AnyCircuitElement,
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
Expand Down
15 changes: 15 additions & 0 deletions src/fn/sod123.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { z } from "zod"
import { rectpad } from "../helpers/rectpad"
import { silkscreenRef, type SilkscreenRef } from "src/helpers/silkscreenRef"
import { length } from "circuit-json"
import {
createManualDiodeFabricationNotes,
diodeFabricationTuningPresets,
} from "../helpers/manual-diode-fabrication"
import { base_def } from "../helpers/zod/base_def"

export const sod_def = base_def.extend({
Expand All @@ -19,6 +23,16 @@ export const sod123 = (
raw_params: z.input<typeof sod_def>,
): { circuitJson: AnyCircuitElement[]; parameters: any } => {
const parameters = sod_def.parse(raw_params)

const fabricationNotes = createManualDiodeFabricationNotes({
pin1PadX: -length.parse(parameters.p) / 2,
pin2PadX: length.parse(parameters.p) / 2,
padWidth: length.parse(parameters.pl),
padHeight: length.parse(parameters.pw),
bodyWidth: length.parse(parameters.w),
bodyHeight: length.parse(parameters.h),
tuning: diodeFabricationTuningPresets.sod123,
})
const silkscreenRefText: SilkscreenRef = silkscreenRef(
0,
length.parse(parameters.h) / 4 + 0.4,
Expand All @@ -39,6 +53,7 @@ export const sod123 = (

return {
circuitJson: sodWithoutParsing(parameters).concat(
fabricationNotes as AnyCircuitElement[],
silkscreenRefText as AnyCircuitElement,
courtyard as AnyCircuitElement,
),
Expand Down
Loading
Loading