Skip to content

feat: add mark.trendline opt-out for scatter regression line#88

Merged
rileyhilliard merged 1 commit into
mainfrom
feat/scatter-trendline-opt-out
Jul 4, 2026
Merged

feat: add mark.trendline opt-out for scatter regression line#88
rileyhilliard merged 1 commit into
mainfrom
feat/scatter-trendline-opt-out

Conversation

@rileyhilliard

Copy link
Copy Markdown
Member

Problem

Scatter charts render a least-squares regression trend line unconditionally, with no way to turn it off. When a chart draws its own reference line — e.g. a manual x=y diagonal in a separate layer — the auto trend line adds a second, competing diagonal.

The AISD-takeover D/F scatter has an intentional x=y reference line; the auto trend line drew a misaligned dashed diagonal on top of it.

Fix

Add mark.trendline (default true, so existing charts are unchanged) and gate the renderer on markDef.trendline !== false. Authors suppress the auto line with mark: { type: 'point', trendline: false }.

Tests

  • renders a trend line by default
  • suppresses the trend line when mark.trendline is false

Engine suite: 1573 passing.

Scatter charts rendered a least-squares trend line unconditionally.
When a chart draws its own reference line (e.g. a manual x=y diagonal
in a separate layer), the auto trend line produced a second, competing
diagonal.

Add `mark.trendline` (default true, so no behavior change) and gate the
renderer on `markDef.trendline !== false`. Authors suppress the auto
line with `mark: { type: 'point', trendline: false }`.
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rileyhilliard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab422e5d-6b30-4485-af32-b099af1db923

📥 Commits

Reviewing files that changed from the base of the PR and between 51cd77d and 6be87f2.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • packages/core/src/types/spec.ts
  • packages/engine/src/charts/scatter/__tests__/compute.test.ts
  • packages/engine/src/charts/scatter/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/scatter-trendline-opt-out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rileyhilliard rileyhilliard merged commit 6fe79ba into main Jul 4, 2026
2 checks passed
@rileyhilliard rileyhilliard deleted the feat/scatter-trendline-opt-out branch July 4, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant