feat: add mark.trendline opt-out for scatter regression line#88
Conversation
Scatter charts rendered a least-squares trend line unconditionally.
When a chart draws its own reference line (e.g. a manual x=y diagonal
in a separate layer), the auto trend line produced a second, competing
diagonal.
Add `mark.trendline` (default true, so no behavior change) and gate the
renderer on `markDef.trendline !== false`. Authors suppress the auto
line with `mark: { type: 'point', trendline: false }`.
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Scatter charts render a least-squares regression trend line unconditionally, with no way to turn it off. When a chart draws its own reference line — e.g. a manual x=y diagonal in a separate layer — the auto trend line adds a second, competing diagonal.
The AISD-takeover D/F scatter has an intentional x=y reference line; the auto trend line drew a misaligned dashed diagonal on top of it.
Fix
Add
mark.trendline(defaulttrue, so existing charts are unchanged) and gate the renderer onmarkDef.trendline !== false. Authors suppress the auto line withmark: { type: 'point', trendline: false }.Tests
renders a trend line by defaultsuppresses the trend line when mark.trendline is falseEngine suite: 1573 passing.