feat: honor explicit domain and range on scatter bubble size scale#87
Conversation
The bubble size scale always derived its domain from data min/max and hard-coded the radius range to [3, 30], ignoring encoding.size.scale.domain/range. On a scatter with points clustered in a small region, the largest datum always mapped to a 30px radius (60px diameter), blobbing dense clusters into one mass with no author lever to shrink them. Read encoding.size.scale.domain and .range when present: a domain wider than the data keeps the largest datum below the max radius, and an explicit range caps the radii. Clamp the scale so an author-narrowed domain never yields out-of-range radii. Falls back to the previous data-derived domain and [3, 30] range when unset.
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The scatter bubble size scale always derived its domain from data min/max and hard-coded the radius range to
[3, 30], ignoringencoding.size.scale.domain/.range. When points cluster in a small region, the largest datum always maps to a 30px radius (60px diameter), so dense clusters blob into one mass and the author has no lever to shrink them.Concretely: the AISD-takeover D/F scatter has three large pink bubbles (
sz: 300) sitting on top of each other in the low-pass-rate corner.Fix
Read
encoding.size.scale.domainand.rangewhen present:Falls back to the previous data-derived domain and
[3, 30]range when unset — no behavior change for existing bubble charts.Tests
explicit size domain keeps the largest datum below the max radiusexplicit size range caps the radiiScatter suite: 40 passing.