Skip to content

feat: honor explicit domain and range on scatter bubble size scale#87

Merged
rileyhilliard merged 1 commit into
mainfrom
feat/scatter-size-scale-override
Jul 4, 2026
Merged

feat: honor explicit domain and range on scatter bubble size scale#87
rileyhilliard merged 1 commit into
mainfrom
feat/scatter-size-scale-override

Conversation

@rileyhilliard

Copy link
Copy Markdown
Member

Problem

The scatter bubble size scale always derived its domain from data min/max and hard-coded the radius range to [3, 30], ignoring encoding.size.scale.domain / .range. When points cluster in a small region, the largest datum always maps to a 30px radius (60px diameter), so dense clusters blob into one mass and the author has no lever to shrink them.

Concretely: the AISD-takeover D/F scatter has three large pink bubbles (sz: 300) sitting on top of each other in the low-pass-rate corner.

Fix

Read encoding.size.scale.domain and .range when present:

  • a domain wider than the data keeps the largest datum below the max radius
  • an explicit range caps the radii outright
  • the scale clamps, so an author-narrowed domain never yields out-of-range radii

Falls back to the previous data-derived domain and [3, 30] range when unset — no behavior change for existing bubble charts.

Tests

  • explicit size domain keeps the largest datum below the max radius
  • explicit size range caps the radii

Scatter suite: 40 passing.

The bubble size scale always derived its domain from data min/max and
hard-coded the radius range to [3, 30], ignoring
encoding.size.scale.domain/range. On a scatter with points clustered in
a small region, the largest datum always mapped to a 30px radius (60px
diameter), blobbing dense clusters into one mass with no author lever
to shrink them.

Read encoding.size.scale.domain and .range when present: a domain wider
than the data keeps the largest datum below the max radius, and an
explicit range caps the radii. Clamp the scale so an author-narrowed
domain never yields out-of-range radii. Falls back to the previous
data-derived domain and [3, 30] range when unset.
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rileyhilliard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a2b176fb-5861-41a5-9ec8-b7e530ca2893

📥 Commits

Reviewing files that changed from the base of the PR and between 10ae705 and c373174.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • packages/engine/src/charts/scatter/__tests__/compute.test.ts
  • packages/engine/src/charts/scatter/compute.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/scatter-size-scale-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rileyhilliard rileyhilliard merged commit 718d53d into main Jul 4, 2026
2 checks passed
@rileyhilliard rileyhilliard deleted the feat/scatter-size-scale-override branch July 4, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant