fix(nemo_guardrails):Revert MCP Gateway integration with NeMo Guardrails - #874
fix(nemo_guardrails):Revert MCP Gateway integration with NeMo Guardrails#874christinaexyou wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (9)
📝 WalkthroughWalkthroughThe change removes MCP Gateway and BBR plugin API fields, status handling, reconciliation, EnvoyFilter resources, templates, tests, RBAC permissions, and policy allowlist entries from the Nemo Guardrails operator. ChangesMCP Gateway integration removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The MCP Gateway integration created a dependency on Inference Payload Processing's (IPP) NeMo BBR plugins which will soon be replaced. If `MCPGateway` is defined on the `NemoGuardrailsPodTemplate` without a custom deployment of the BBR plugin, it will cause theNeMo Guardrails server deployment to fail. Fix: remove `controllers/nemo_guardrails/envoy_filter.go`, `controllers/nemo_guardrails/mcp_gateway.go`, `controllers/nemo_guardrails/mcp_gateway_test.go`, `controllers/nemo_guardrails/templates/envoy-filter.tmpl.yaml` and related changes on other files. This reverts commit 9b9abea.
3925f81 to
6b150ea
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: m-misiura The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@christinaexyou: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
The MCP Gateway integration created a dependency on Inference Payload Processing's (IPP) NeMo BBR plugins which will soon be replaced. If
MCPGatewayis defined on theNemoGuardrailsPodTemplatewithout a custom deployment of the BBR plugin, it will cause theNeMo Guardrails server deployment to fail.Fix: remove
controllers/nemo_guardrails/envoy_filter.go,controllers/nemo_guardrails/mcp_gateway.go,controllers/nemo_guardrails/mcp_gateway_test.go,controllers/nemo_guardrails/templates/envoy-filter.tmpl.yamland related changes on other files.This reverts commit 9b9abea. Resolves RHAISTRAT-2379
Summary by CodeRabbit