Rename AnalysisInfo field to SecretParts on detectors.Result#4911
Open
mcastorina wants to merge 1 commit intomainfrom
Open
Rename AnalysisInfo field to SecretParts on detectors.Result#4911mcastorina wants to merge 1 commit intomainfrom
mcastorina wants to merge 1 commit intomainfrom
Conversation
Mechanical rename of the detectors.Result.AnalysisInfo field to SecretParts to prepare for its replacement for Raw.
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mechanical rename of the detectors.Result.AnalysisInfo field to SecretParts to prepare for its replacement for Raw.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Broad mechanical rename of a core struct field used across many detectors and tests; risk is mainly compile/runtime breakage for downstream code expecting
AnalysisInfoand any analyzers/output paths not fully updated.Overview
Renames the
detectors.Resultfield used to pass analyzer inputs fromAnalysisInfotoSecretParts, updating the struct comment to reflect multi-part credential components.Updates a large set of detectors to populate
SecretParts(instead ofAnalysisInfo) on verified results, and adjusts integration/unit tests to ignore/clearSecretPartsaccordingly.Tweaks plain-text output (
pkg/output/plain.go) to show the analysis hint based onSecretPartsbeing present for verified results.Reviewed by Cursor Bugbot for commit 7185681. Bugbot is set up for automated code reviews on this repo. Configure here.