[INS-455] Unify common logic in Atlassian Data Center detectors

[mustansir14]

Background

Three detectors target Atlassian Data Center (self-hosted) products: JiraDataCenterPAT, ConfluenceDataCenter, and BitbucketDataCenter. Reviewing them side-by-side revealed significant duplication: identical structural-validation logic, the same bearer-auth HTTP plumbing, and the same URL-extraction pipeline repeated verbatim in each file.

What changed

New shared package: pkg/detectors/atlassiandatacenter/

Following the pattern established by pkg/detectors/aws/, the three detectors are now co-located under a common parent that also houses shared utilities in common.go.

GetDCTokenPat(prefixes []string) *regexp.Regexp
Returns the compiled PAT regex for Jira/Confluence DC tokens (44-char base64 strings whose decoded form is <numeric-id>:<random-bytes>). Previously each detector hand-rolled the same pattern with inline literal strings.

IsStructuralPAT(candidate string) bool
Validates that a base64 candidate decodes to the <digits>:<bytes> structure. This function was copy-pasted verbatim between Jira and Confluence.

GetURLPat(prefixes []string) *regexp.Regexp
Returns the compiled URL regex for self-hosted Atlassian instance URLs. Each detector calls this once at package init time and stores the result in a package-level var, preserving the same compile-once behaviour as before. go-re2 compiles via CGo/FFI so doing this per-chunk would be a meaningful regression.

FindEndpoints(data string, urlPat *regexp.Regexp, resolve func(...string) []string) []string
Extracts keyword-scoped URLs from a chunk using the pre-compiled urlPat, passes them through s.Endpoints (which merges configured endpoints), deduplicates, and strips trailing slashes. All three detectors had their own multi-step version of this pipeline.

MakeVerifyRequest(ctx, client, fullURL, token string) (bool, map[string]any, error)
Sends a Bearer-authenticated GET and interprets the response: 200 → (true, decoded-JSON-body, nil), 401 → (false, nil, nil), other → (false, nil, error). Previously each detector built the request inline and contained its own copy of the 200 / 401 / default status-code switch. Jira reads body["displayName"] and body["emailAddress"] from the returned map; Confluence and Bitbucket discard it.

Detector changes

Each detector now imports the shared package and delegates to it:

Before	After
Private isStructuralPAT (Jira + Confluence)	atlassiandatacenter.IsStructuralPAT
Inline PAT regex literal (Jira + Confluence)	atlassiandatacenter.GetDCTokenPat(keywords)
10–15 line URL-find + dedup + resolve block (all three)	atlassiandatacenter.FindEndpoints(...)
Inline request build + status-code switch (all three)	atlassiandatacenter.MakeVerifyRequest(...)

The URL regex is also standardised across all three detectors. Confluence and Bitbucket previously used an unbounded \d+ port pattern and allowed hostnames starting with . or -; all three now use [a-zA-Z0-9][a-zA-Z0-9.\-]* with \d{1,5} for the port (matching the stricter Jira original).

A keywords package-level variable is introduced in Jira (Confluence and Bitbucket already had one) so the keyword list is defined once and reused by the regex, FindEndpoints, and Keywords().

TestIsStructuralPAT migrated

The structural-PAT test previously lived in jiradatacenterpat_test.go and called the private function. It is now in common_test.go and covers tokens from all three products. common_test.go also adds tests for GetDCTokenPat, FindEndpoints, and MakeVerifyRequest.

What did not change

• Each detector retains its own package, Scanner type, Keywords(), Type(), Description(), and FromData() logic.
• Jira's JSON response parsing (displayName, emailAddress) is unchanged.
• Confluence's invalidHosts cache and errNoHost sentinel are unchanged.
• Bitbucket's ?limit=1 query parameter is unchanged.
• All existing tests pass without modification.

Corpora Tests

Checklist:

• Tests passing (make test-community)?
• Lint passing (make lint this requires golangci-lint)?

---

Note

Medium Risk
Mostly a refactor, but it changes shared URL matching/endpoint extraction and verification plumbing across three detectors, which could impact detection/verification behavior and false positive/negative rates.

Overview
Consolidates duplicated logic across Atlassian Data Center detectors by introducing a new shared atlassiandatacenter helper package for PAT/URL regexes, endpoint extraction, structural PAT validation, and a common Bearer-auth verification request helper.

Updates the Jira/Confluence/Bitbucket DC detectors to delegate to these shared helpers (including a standardized, slightly stricter URL pattern), removes their inlined structural/HTTP code, and relocates detector imports in defaults.go/tests (plus registering Bitbucket DC as a no-cloud-endpoint detector). Adds a comprehensive common_test.go covering the new helpers and moves structural-PAT tests out of Jira-specific tests.

^{Reviewed by Cursor Bugbot for commit 7c19046. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7c19046. Configure here.}

[cursor]

Bitbucket detector silently added to default scanner list

Medium Severity

The bitbucketdatacenter.Scanner{} is being newly registered in the default detector list (both import and scanner instantiation are pure additions with no corresponding removal). The detector previously existed as code but was not included in the default scan engine. This PR's stated goal is to "unify common logic," but silently enabling a previously-unregistered detector in production scans could produce unexpected new findings and has performance implications. The addition to noCloudEndpointDetectors in the test file confirms this is a net-new registration.

Additional Locations (2)

• pkg/engine/defaults/defaults.go#L97-L98
• pkg/engine/engine_test.go#L1383-L1384

 

^{Reviewed by Cursor Bugbot for commit 7c19046. Configure here.}

[MuneebUllahKhan222]

This is completely irrelevant to the goal of this PR. But can you please add similar logic in bitbucketdatacenter detector

if !emitted {
	// No reachable URL in context — emit an unverified token-only
	// result and annotate why we couldn't verify.
	results = append(results, detectors.Result{
		DetectorType: detector_typepb.DetectorType_ConfluenceDataCenter,
		Raw:          []byte(token),
		RawV2:        []byte(token),
		ExtraData: map[string]string{
			"verification_note": "no reachable Confluence Data Center URL found in context; token reported unverified",
		},
	})
}

[MuneebUllahKhan222]

Couple of changes that need to be addressed, Other than that the PR is good to go.

[MuneebUllahKhan222]

No need to do TrimRight here because we are already doing that in FindEndpoints function.

[MuneebUllahKhan222]

We can get rid of all this and do

baseURL + "/rest/api/1.0/projects?limit=1"

[MuneebUllahKhan222]

We can get rid of all this and do

baseURL + "/rest/api/2/myself"