adding customizable successRanges and rotatedRanges to customDetector#4892
Open
jordanTunstill wants to merge 2 commits intomainfrom
Open
adding customizable successRanges and rotatedRanges to customDetector#4892jordanTunstill wants to merge 2 commits intomainfrom
jordanTunstill wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be9bfc5. Configure here.
…o that an earlier ranged verifier's rangesInEffect = true can't trigger a spurious SetVerificationError after the legacy verifier already confirmed the secret as live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
This would allow users to add successRanges and rotatedRanges to their customDetectors, for verification purposes, allowing them control/configuration over what is considered live/rotated for these custom detections.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Changes custom detector verification semantics based on HTTP status codes and adds a new proto field, which could affect how secrets are marked verified/unverified and how verification errors are reported.
Overview
Custom detector webhook verification now supports configurable HTTP status success and rotated code ranges via
successRangesand the newrotatedRanges, allowing verifiers to mark secrets as live, rotated, or inconclusive based on status codes (while keeping legacy behavior when neither is provided).This adds range matching/validation utilities, updates
NewWebhookCustomRegexto validate both range sets, records truncated verifier responses on “live” outcomes, and introduces tests covering YAML parsing, range validation/matching, mixed legacy+ranged verifier behavior, and verification error handling when responses match neither configured set.Reviewed by Cursor Bugbot for commit 532003f. Bugbot is set up for automated code reviews on this repo. Configure here.