Skip to content

GitAuto setup #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gitauto-ai wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GitAuto setup #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e4debb
Add tsconfig.test.json with relaxed settings
gitauto-ai[bot] Jul 16, 2026
7cc6f19
Update tsconfig.test.json [skip ci]
gitauto-ai[bot] Jul 16, 2026
0a1f890
Empty commit to trigger final tests
gitauto-ai[bot] Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
// Relax unused-variable checks to avoid false positives in test callbacks and mocks.
"noUnusedLocals": false,
"noUnusedParameters": false
}
}
Comment on lines +1 to +8

@llamapreview llamapreview Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: Medium

The new tsconfig.test.json disables noUnusedLocals and noUnusedParameters for all test files. While this prevents build failures from test-specific patterns (e.g., unused done callbacks), it also suppresses detection of genuinely dead code or unintentional unused variables and parameters across the entire test suite. Over time, this can lead to accumulation of unused code, reducing readability and potentially masking logic errors. The change lacks any documentation explaining why these checks are disabled, which hinders future maintainers. Since the decision is intentional and not a bug, the issue is a low-priority maintainability concern.

Code Suggestion:

{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    // Relax unused-variable checks to avoid false positives in test callbacks and mocks.
    "noUnusedLocals": false,
    "noUnusedParameters": false
  }
}

@gitauto-ai gitauto-ai Bot Jul 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to tsconfig.test.json explaining the rationale for disabling noUnusedLocals and noUnusedParameters.

@gitauto-ai gitauto-ai Bot Jul 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed the reviewer's feedback by adding the requested comment to tsconfig.test.json and replying to the comment. I have verified the change. No other feedback was provided.