Skip to content

Support for receiving websocket events#2

Open
svoynow wants to merge 6 commits into
trestrantham:masterfrom
labzero:master
Open

Support for receiving websocket events#2
svoynow wants to merge 6 commits into
trestrantham:masterfrom
labzero:master

Conversation

@svoynow

@svoynow svoynow commented Jan 12, 2017

Copy link
Copy Markdown

I thought it would be cool to be able to get "Now Playing" functionality to e.g. Slack without having to poll.
So added the ability to get a websocket connection to listen for events from Mopidy and some additional parsing logic to handle the data nicely.

Let me know if there's anything I can do to make this more merge-able.

Comment thread lib/mopidy/events.ex
@@ -0,0 +1,12 @@
defmodule Mopidy.Events do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules should have a @moduledoc tag.

Comment thread lib/mopidy.ex
end


defmodule Mopidy.Websocket do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules should have a @moduledoc tag.

@svoynow

svoynow commented Jan 12, 2017

Copy link
Copy Markdown
Author

Looks like the travis build failed because I bumped the Poison version. I assume that's fixable by tweaking the build config.

@coveralls

coveralls commented Jan 20, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 1.63% when pulling bff8cd2 on labzero:master into 8be9cc2 on trestrantham:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants