-
Notifications
You must be signed in to change notification settings - Fork 0
v0.3.0 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
v0.3.0 #36
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4469114
Refactor API helpers to use Appliance methods
codefitz ab084eb
Add tabulate to install_requires (#35)
Copilot bfcdd4e
Remove deprecated helper functions and update docs
codefitz f49dc30
Update API version support to 1.16 and add admin API notebook
codefitz afcc905
Update admin API example notebook and docs
codefitz 7b20758
Add admin consolidation notebook and update API examples
codefitz ab38e3f
Rename admin API notebook for clarity
codefitz 9bd079c
Add Tideway Credentials API example notebook
codefitz 67ee438
Add example notebooks for Tideway REST APIs
codefitz 8265e1f
Update README.md
codefitz ed69325
Update docs/index.md
codefitz a981363
Fixed pull request suggestions.
codefitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| Repository: Tideway (BMC Discovery API client) | ||
|
|
||
| Mission | ||
| - Add or adjust API helpers using the top-level REST wrappers in `tideway/main.py` (`Appliance.get/post/patch/put/delete`). Do not call `requests` or `discoRequests` directly from feature modules, except the explicit non-standard schema endpoints (`/about`, swagger/openapi) which are intentionally direct in `main.py`. | ||
| - Preserve parameter handling: set `self.params[...]` before calling a wrapper; the appliance layer resets params after each request. | ||
| - Maintain existing deprecation warnings; when adding aliases, warn with `DeprecationWarning` and point to the preferred helper. | ||
|
|
||
| Uploads and special payloads | ||
| - Use `Appliance.post(..., files=..., content_type=...)` for multipart uploads (TKU/knowledge, Kerberos keytabs/ccaches). Do not reintroduce `discoRequests` helpers in new code. | ||
| - When a response needs a specific MIME type (e.g., licensing CSV/raw), pass `response="application/zip"` or similar via the wrapper. | ||
|
|
||
| Style and safety | ||
| - Keep code ASCII-only unless the file already uses Unicode. Keep comments minimal and clarifying, not redundant. | ||
| - Do not remove or overwrite user changes; avoid destructive git commands. | ||
|
|
||
| Validation | ||
| - Preferred quick check: `python3 -m compileall tideway`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This initiation guide documents
ssl_verifywith a default ofFalseand recommends leaving it at that value for self-signed HTTPS, which means the client will skip TLS certificate validation by default. A network attacker can exploit this to present a forged certificate, transparently intercepting or altering all API traffic from the Tideway client. Change the default and guidance so certificate verification is enabled by default (e.g.,ssl_verify=Truewith a trusted CA bundle) and reservessl_verify=Falsefor exceptional, short-lived testing only.