fix(fp-check): scope hooks and make Stop path-aware#190
Open
GotenJBZ wants to merge 1 commit into
Open
Conversation
Author
|
Adding as a reviewer both @remiforall and @computerality since they both tried to solve this exact problem. EDIT: I cannot do that :ops: |
f9e3ad8 to
ba0a2d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143. Supersedes #188.
Problems (in
main)StopandSubagentStopboth usematcher: "*", so they run on every subagent/agent stop in any session where fp-check is installed.Stopprompt demands the full deep-path output (5 phases, 13 questions, full PoC) for every bug. Standard-path verifications are rejected as "incomplete".Changes
Stophook moved into skill frontmatter. This way, the stop hooks will be executed only when the skill is loaded, avoiding the firing in unrelated sessions.Stophook prompt as ordered rules: (1) skip if not fp-check (2) skip if delegated to subagents/workflow, (3) check only the path actually used (standard vs deep)SubagentStopremains inhooks.json, narrowing the matcher to only support specific subagentsdata-flow-analyzer|exploitability-verifier|poc-builder