[pull] master from golang:master#117
Merged
Merged
Conversation
After CL 795460, a couple of longtest builders got broken because the max header value count for incoming requests was set by default to 500, yet the subject benchmark operates on 1,000 headers so this change simply gives it more breathing space by 30+nheaders. Updates #79936 Fixes #80230 Change-Id: I0ab8a699be062ca967d090a070b803d8137453f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/796520 Reviewed-by: Nicholas Husin <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Emmanuel Odeke <[email protected]> Reviewed-by: Nicholas Husin <[email protected]> LUCI-TryBot-Result: [email protected] <[email protected]>
Take a temporary replace directive in the go.mod for the crypto/internal/cryptotest/wycheproof/_schema go.mod on a yet-to-be-merged upstream fix to atombender/go-jsonschema. This fixes a limitation where schemas with certain unmodelled properties (e.g. conditional validation requirements) would result in the generated code using a generic interface type instead of a structure. With this in place the ML-DSA wycheproof test can lose its manually defined structure + unmarshalling code in favour of using the generated structure type that's always in-sync with upstream. Change-Id: Ibbd7b41aaa0caf6414b319b77e62762b498ed6f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/795301 Reviewed-by: Filippo Valsorda <[email protected]> Auto-Submit: Daniel McCarney <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: [email protected] <[email protected]> Reviewed-by: Hongxiang Jiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )