Cross-section follow-ups: outline, Clip discard, sketch import, toast log#222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
EzyCad_tests --gtest_filter=Shp_cross_section.*:Shp_test.Cross_section*ezy.msgtoousage.md,usage-settings.md, CHANGELOG)Closes #221
Related: #218 #219
Note
Medium Risk
Changes touch modeling (Clip deletes geometry, sketch import from OCCT section) and global status logging; behavior is covered by new tests but Clip/sketch paths affect user documents.
Overview
Follow-ups on the Shape cross-section tool and status messaging.
Cross-section: Show section outline (default off) toggles cyan intersection wires from a cached compound without recomputing. Clip no longer errors when a solid is fully on the discarded side—it deletes those inputs with no replacement and reports counts; survivors still become clipped replacements (undoable). Cross section sketch waits for section work if needed, builds a sketch on the cutting plane, imports line and circle edges (full circles split into two semicircles), runs
rebuild_faces(), commits undo, and switches to sketch inspection; other curve types are skipped.Status / Log:
GUI::show_messageandezy.msgnow append the same text to the Log window.show_error_dialoglogstitle: messageonce and shows only the title in the toast to avoid duplicate log lines.Docs, CHANGELOG, agent plan status, and unit tests cover outline toggle, full discard on clip, and box midplane sketch import.
Reviewed by Cursor Bugbot for commit 18b5c0d. Bugbot is set up for automated code reviews on this repo. Configure here.