fix(traefik): allow any extraValues for templating in extraObjects - #1739
Open
xe-leon wants to merge 2 commits into
Open
fix(traefik): allow any extraValues for templating in extraObjects#1739xe-leon wants to merge 2 commits into
xe-leon wants to merge 2 commits into
Conversation
Signed-off-by: Evgenii Domashenkin <[email protected]>
Signed-off-by: Evgenii Domashenkin <[email protected]>
bpsoraggi
added
status/0-needs-triage
kind/proposal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added extraValues to the JSON schema as an open object (additionalProperties: true), enabling users to pass any custom key-value pairs that can be referenced inside extraObjects templates via {{ .Values.extraValues.* }}.
Motivation
Fixes #1738
More
make testand all the tests passed