fix(generator): strip PyPI Trove prefix, sort components properly - #7
Merged
traefiker merged 2 commits intoMay 12, 2026
Merged
Conversation
…nd LICENSE case-insensitively
mmatur
force-pushed
the
fix/python-licenses-and-component-order
branch
from
May 12, 2026 14:55
4a75e66 to
9f17db5
Compare
bpsoraggi
reviewed
May 12, 2026
bpsoraggi
left a comment
bpsoraggi
left a comment
Contributor
There was a problem hiding this comment.
LMGTM, but there's still an issue with the License :: OSI Approved :: prefix in some cases, as seen when testing with the generated traefikee sbom
mmatur
force-pushed
the
fix/python-licenses-and-component-order
branch
from
May 12, 2026 17:02
ce5ff44 to
08cc2bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
License :: OSI Approved :: …) before the license-map / SPDX lookup, so Python deps no longer need one bandaidLicenseRef-License-OSI-Approved-*entry per classifier.Name+Versionstring-concat sort with a cascadingName → Version → PURL → URL → Copyrightcomparator (the old one ordered e.g.acorn-jsx 5.3.2beforeacorn 8.12.1).LICENSEfiles case-insensitively, preserving preferred-name order.Motivation
Fixes the rough edges surfaced while wiring assimilis into the Traefik release pipeline (traefik/traefik#13031). Sort and case-sensitivity fixes originate from @bpsoraggi's
fix/component-orderbranch, folded in here without the no-op double-sort.Additional Notes
End-to-end check on the SBOM from traefik/traefik#13031 (1344 components, 27 PyPI deps with
License :: OSI Approved ::): identicalNOTICE.md/THIRD_PARTY_LICENSES.htmlmodulo the corrected ordering, noLicenseRef-*leak.