Cpu: Allow more threads than cores#1426
Merged
Merged
Conversation
Set `needs_parallelism` for `SyncCube` so the scheduler never queues two units of the same cube on one worker, which would deadlock the spin barrier. Clamp the hardcoded cube dims in the shared saturating and synchronization runtime tests to `max_units_per_cube` so they pass on machines with fewer than 16 cores (e.g. CPU CI). Drops the earlier unnecessary changes: the MLIR `thread_yield` extern in `sync_cube` (bad for a barrier that must resolve ASAP) and the loud `max_units_per_cube` launch enforcement. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.