Skip to content

fix(automerge): gate fleet CI templates (templates/ci-workflows/**) #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topcoder1 merged 1 commit into from
Jul 16, 2026
Merged

fix(automerge): gate fleet CI templates (templates/ci-workflows/**) #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/claude-author-automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ jobs:
^docker-compose.*\.ya?ml$
(^|/)docker/docker-compose.*\.ya?ml$
^\.github/workflows/.*
^templates/ci-workflows/.*
^\.github/actions?/.*
^\.github/scripts/.*
(^|/)action\.ya?ml$
Expand Down
18 changes: 18 additions & 0 deletions selftest/risk_patterns_corpus.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ RISKY: .github/workflows/deploy.yml
RISKY: .github/workflows/lint.yml
RISKY: .github/risk-paths.yml
RISKY: .github/CODEOWNERS

# ── RISKY: fleet CI templates (2026-07-16 gap — dotclaude#157) ─────────────
# The caller templates + fleet automation under templates/ci-workflows/ are the
# SOURCE of every repo's .github/workflows/*.yml. A Claude PR editing them
# self-merged in ~90s (dotclaude#157) because the regex only knew the rendered
# artifact, not its source — inverted blast radius: the rendered copy was gated
# on 45 repos while the template that feeds all 45 was not. dotclaude has no
# pr-classify, so risk-paths.yml can't gate it there; this is the only lever.
# scripts/ matters most: merge-workflow-only-pr.sh drops branch protection.
RISKY: templates/ci-workflows/callers/pr-review.yml
RISKY: templates/ci-workflows/callers/claude-author-automerge.yml
RISKY: templates/ci-workflows/scripts/merge-workflow-only-pr.sh
RISKY: templates/ci-workflows/scripts/rotate-anthropic-key.sh
# BB-only: GH workflow doesn't include bitbucket-pipelines pattern (irrelevant to GH repos)
RISKY_BB: bitbucket-pipelines.yml

Expand Down Expand Up @@ -264,3 +277,8 @@ SAFE: .github/actionlint.yml
# GitHub only reads dependabot config under .github/ — a root copy is inert
SAFE: dependabot.yml
SAFE: docs/dependabot-setup.md

# ── SAFE: templates/ near-misses (the ci-workflows glob must not over-block) ──
SAFE: templates/email/welcome.html
SAFE: templates/ci-workflows-notes.md
SAFE: docs/ci-workflows/overview.md
1 change: 1 addition & 0 deletions selftest/test_automerge_risk_patterns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ patterns='^(.*/)?(auth|login|signin|signup|logout|session[s]?|oauth|oauth2|sso|j
^docker-compose.*\.ya?ml$
(^|/)docker/docker-compose.*\.ya?ml$
^\.github/workflows/.*
^templates/ci-workflows/.*
^\.github/actions?/.*
^\.github/scripts/.*
(^|/)action\.ya?ml$
Expand Down
Loading