Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add contact tags #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add contact tags #421
Changes from all commits
0c25f26495f7eccf2c71041d2ed18d4f80ecbd92290c48dcf8026d10d01bf174d09babe6f95c5c7607c093c9606acd79ff913e9cdFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync doesn't propagate tag deletions
The merge strategy here is purely additive: it takes
sharedTags ∪ localOnlyTagsand writes the union back to local. That means if a user on client A removes a tag and syncs, client B will never learn about the deletion — the tag stays on B forever.The same additive-only pattern is used in
pushSubTablesToShared(only inserts new tags, never deletes). This is consistent with how some other sub-tables are handled, but for an explicitly user-removable attribute like tags it's a meaningful limitation worth calling out in docs or comments.If you want true delete propagation you'd need a tombstone/deletion-log table (hard). A middle ground is "shared wins on delete" — delete local tags not present in shared during merge — but that would silently remove legitimately local-only tags. At minimum this behaviour should be documented here so future developers don't assume deletions propagate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
db.prepare()inside a loop re-parses the SQL on every iteration. Hoist it above the loop:Same pattern applies in
pushSubTablesToShared.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
border-radius: 0on a button elementPer the project design system (CLAUDE.md): "All interactive elements (buttons, inputs, selects, textareas) use
border-radius: 0— square corners everywhere, no exceptions." The.tags-chip-removebutton needs an explicit reset here, even if the global stylesheet may default to 0, to be safe across browser agents and to follow the convention used elsewhere.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.