Skip to content

refactor(media): scan clips|loops|wipes at ingest root - #50

Merged
kubo6472 merged 2 commits into
mainfrom
cursor/flat-media-paths-d3e2
Aug 4, 2026
Merged

refactor(media): scan clips|loops|wipes at ingest root#50
kubo6472 merged 2 commits into
mainfrom
cursor/flat-media-paths-d3e2

Conversation

@kubo6472

@kubo6472 kubo6472 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Remove spravy// nesting from media listing and picker UX. Payload paths stay two-level (e.g. clips/foo.mp4).

Summary by CodeRabbit

  • New Features

    • Updated media ingest to use dedicated clips, loops, and wipes directories under the configured ingest root.
    • Media paths now use consistent POSIX-relative locations, such as clips/<file>.mp4.
    • Media picker fields now reflect the configured subdirectory and display clearer folder guidance.
  • Documentation

    • Updated ingest settings help text and media path guidance to describe the new layout.
    • Clarified how media folders are resolved relative to the ingest root.

Remove spravy/<rundownId>/ nesting from media listing and picker UX.
Payload paths stay two-level (e.g. clips/foo.mp4).
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b3e639e5-09da-4912-aae8-1559f26387ae

📥 Commits

Reviewing files that changed from the base of the PR and between 240a582 and e5ee8b0.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

📝 Walkthrough

Walkthrough

The media ingest layout now stores media in clips, loops, and wipes directories under INGEST_MEDIA_ROOT. Backend paths, frontend picker paths, tests, and documentation no longer use rundown-specific directories.

Changes

Media ingest layout

Layer / File(s) Summary
Backend media path resolution
backend/src/background/media.ts, backend/src/background/interfaces.ts, backend/src/background/api/pieces.export.test.ts
Media paths now resolve from sanitized subdirectories under the ingest root. Contracts and export fixtures use paths such as clips/vo.mp4.
Frontend media picker paths
frontend/src/components/rundown/mediaPickerField.tsx
The media picker uses the configured subdirectory for logical paths and placeholders. The product name spelling is corrected.
Media layout documentation
README.md, frontend/src/components/settings/coreConnectionSettingsForm.tsx
Documentation describes the clips/, loops/, and wipes/ layout and two-level clip paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main media layout change at the ingest root.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/flat-media-paths-d3e2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 97: Add the text language identifier to the fenced path-only code block
in README.md, changing its opening fence to ```text while preserving the block
contents and closing fence.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ff68312a-3ee1-402a-a9d3-ebf0bb494fef

📥 Commits

Reviewing files that changed from the base of the PR and between 012f16c and 240a582.

📒 Files selected for processing (6)
  • README.md
  • backend/src/background/api/pieces.export.test.ts
  • backend/src/background/interfaces.ts
  • backend/src/background/media.ts
  • frontend/src/components/rundown/mediaPickerField.tsx
  • frontend/src/components/settings/coreConnectionSettingsForm.tsx

Comment thread README.md Outdated
Satisfy markdownlint MD040 on the ingest media layout example.
@kubo6472
kubo6472 merged commit 64ca154 into main Aug 4, 2026
8 checks passed
@kubo6472
kubo6472 deleted the cursor/flat-media-paths-d3e2 branch August 4, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants