fix(seeder): seed quote-only products first so front page shows priced products#29
Closed
tkahng wants to merge 1 commit into
Closed
fix(seeder): seed quote-only products first so front page shows priced products#29tkahng wants to merge 1 commit into
tkahng wants to merge 1 commit into
Conversation
…d products The home page fetches the 4 newest products (ORDER BY created_at DESC). Quote-only products (null price) were seeded last, giving them the highest created_at timestamps and causing all 4 front-page slots to show items with no price. Seeding them first ensures priced products are the newest and appear on the home page instead. Adds a test that asserts none of the 4 newest products have a null price.
Owner
Author
|
Superseded by #30 which contains all commits from this branch plus the expanded seeder work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The storefront home page fetches the 4 newest products (
ORDER BY created_at DESC LIMIT 4). Quote-only products (null price) were seeded last inDevDataSeeder, giving them the highestcreated_attimestamps. As a result, all four front-page product slots showed items with no visible price.Fix
Reorder the seeding calls in
run()soseedQuoteOnlyProducts()runs beforeseedProducts()andseedVariantProducts(). Quote-only items receive the oldest timestamps; the priced products are the newest and appear on the home page instead.Tests
Added
seeder_frontPageFeaturedProductsAllHavePrices— queries the 4 newest active products (same logic as the storefront) and asserts that none have a null price.Checklist