Add support for seesaw encoders - #771
Closed
jphastings wants to merge 4 commits into
Closed
Conversation
* lsm6ds3tr: avoid unnecessary heap allocations * lsm6ds3tr: use helper functions, for readability * lsm6ds3tr: return slice of the internal buffer on readBytes
Adafruit's Mini GPS PA1010D Module works with this device driver, but requires 0x10 as the address, rather than 0x42. This change allows the device to be initialised with whatever i2c address is needed, while maintaining backward compatibility. Adds new constants to allow easy configuration of both the ublox device and the PA1010D.
Adds the necessary function addresses for reading and writing encoders on a seesaw. Also provides two helper functions to make this easier.
jphastings
changed the title
The example has moved, so the smoke test script needs to point to the correct directory.
Member
|
Commit b9f2074 has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds function addresses, helper functions and examples for interacting with seesaw rotary encoders, eg. Adafruit's Rotary Encoder Breakout.
I've tested with the Adafruit QT Py RP2040 and the rotary encoder breakout myself — and can confirm the current default delay used is suitable for this functionality as well (I've used the example in this PR successfully down to 250µs too, which is the default delay in the Adafruit library).
I realise the other capabilities of the seesaw don't have helper functions — is this the right approach for this repository?
If it's suitable I'll look at implementing helpers for the interrupt functionality as well 😊