Allow GPS with any i2c address (support PA1010D) - #770
Merged
Conversation
Adafruit's Mini GPS PA1010D Module works with this device driver, but requires 0x10 as the address, rather than 0x42. This change allows the device to be initialised with whatever i2c address is needed, while maintaining backward compatibility. Adds new constants to allow easy configuration of both the ublox device and the PA1010D.
jphastings
changed the title
Member
|
Looks good, thanks for working on this @jphastings I switched the target branch to Now merging, thanks again! |
Contributor
Author
|
Ahh, I didn't spot that part of the contributing guide — thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adafruit's Mini GPS PA1010D Module works with this device driver (personally confirmed), but requires
0x10as the i2c address, rather than0x42.This change allows the device to be initialised with whatever i2c address is needed, while maintaining backward compatibility.
(If backward compatibility isn't needed, please let me know, and I'll remove the function that assumes a default, and force the use of an i2c address to initialise!)
Also adds new constants to allow easy configuration of both the ublox device and the PA1010D.