fix: warn and skip if import() type symbol cannot be resolved#362
Open
wopian wants to merge 1 commit into
Open
fix: warn and skip if import() type symbol cannot be resolved#362wopian wants to merge 1 commit into
wopian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For qualifiers in import() type expressions, symbols may not always be resolvable. For example:
import("node:util").TextEncoderEncodeIntoResultexists in Node 25, but not in Node 24Without this check, exporting types on older Node versions will throw an error on missing symbols.
With the check, the missing type will be logged but will not crash dts-bundle-generator.
While the source of this issue comes from an upstream change that has a pending bug fix (
bun-typesusing a Node 25-exclusive type),dts-bundle-generatoroutright crashing on a missingimport()type is disruptive and breaks our release pipeline as[email protected]depends on this package to export Typescript type definitions.References: