Skip to content

fix(monorepo): path parsing errors#343

Open
Gggpound wants to merge 2 commits into
timocov:masterfrom
Gggpound:fix-monorepo-1210
Open

fix(monorepo): path parsing errors#343
Gggpound wants to merge 2 commits into
timocov:masterfrom
Gggpound:fix-monorepo-1210

Conversation

@Gggpound

Copy link
Copy Markdown

No description provided.

@Gggpound
Gggpound force-pushed the fix-monorepo-1210 branch 2 times, most recently from 88d533f to 3bc3992 Compare December 11, 2024 06:29

@timocov timocov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What issue is this PR solving?

Comment thread src/bundle-generator.ts

if (ts.isExportSpecifier(imp)) {
// export { El1, El2 as ExportedName } from 'module';
// @ts-expect-error wait

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what for what?

Comment thread src/bundle-generator.ts
Comment on lines +1402 to +1403
}${'\n'
}This might lead to unpredictable and unexpected output, and possible breaking changes to your API.${'\n'

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what has changed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants