🐛 Fix REPL error attribution by tracking source per span - #123
Merged
Conversation
timfennis
commented
Mar 22, 2026
timfennis
force-pushed
the
bugfix/repl-error-source-tracking
branch
from
March 22, 2026 12:21
3a33dc0 to
f0dc42d
Compare
timfennis
enabled auto-merge (squash)
March 22, 2026 12:23
timfennis
disabled auto-merge
March 22, 2026 12:23
Add SourceId to Span and a SourceDb registry so each span knows which source string it belongs to. Diagnostics now use codespan-reporting's multi-file support to render errors against the correct source, even when a function defined on a previous REPL line triggers a runtime error. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
timfennis
force-pushed
the
bugfix/repl-error-source-tracking
branch
from
March 22, 2026 12:23
f0dc42d to
658eb57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
SourceIdnewtype andSourceDbregistry tondc_lexerso everySpancarries asource_ididentifying which source string its byte offsets refer to.SpanremainsCopy.Interpreterowns aSourceDband registers each source (REPL line, file, etc.) before lexing, threading theSourceIdthrough the lexer.codespan-reporting's multi-fileFilestrait, looking up the correct source via the span'ssource_idinstead of relying on the caller to pass the right source string.Test plan
cargo clippycleanf := fn x -> x / 0thenf(5)— error should highlightx / 0in the function definition🤖 Generated with Claude Code