Skip to content

fix: drop invalid generic params from JsonApiResourceCollection return types #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alies-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: drop invalid generic params from JsonApiResourceCollection return types #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/JsonApiResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function with($request)
/**
* TODO this may be removed once all supported versions have `newCollection`.
*
* @return JsonApiResourceCollection<int, mixed>
* @return JsonApiResourceCollection
*/
public static function collection(mixed $resource)
{
Expand All @@ -164,7 +164,7 @@ public static function collection(mixed $resource)
}

/**
* @return JsonApiResourceCollection<int, mixed>
* @return JsonApiResourceCollection
*/
public static function newCollection(mixed $resource)
{
Expand Down