This repository was archived by the owner on Feb 2, 2023. It is now read-only.
add files for CI binary distribution#116
Open
hone wants to merge 1 commit into
Open
Conversation
wagenet
reviewed
Sep 7, 2017
wagenet
left a comment
wagenet
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but just take a look at my two comments.
| # if install returned non zero (errored) then we first unpublish and then call false so travis will bail at this line | ||
| # if [[ $INSTALL_RESULT != 0 ]]; then echo "returned $INSTALL_RESULT";node-pre-gyp unpublish;false; fi | ||
| # If success then we arrive here so lets clean up | ||
| # node-pre-gyp clean |
Collaborator
There was a problem hiding this comment.
What's up with this commented out stuff?
| end | ||
|
|
||
| def add_travis_yml_file | ||
| template ".travis.yml", "#{base_path}/.travis.yml" |
Collaborator
There was a problem hiding this comment.
Doesn't technically need to be a template since there are no variables in the file, but this also probably doesn't hurt.
Collaborator
|
@hone what's the status here? |
|
@wagenet potentially we could merge this and address the comments in a separate PR? |
Collaborator
|
@hone I don't have a strong opinion at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate Appveyor and TravisCI configuration files to building binaries with CI.