test: add edge-case tests for fct_cross()#402
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
- Explicit NA levels (exclude = NULL) treated as regular levels - keep_empty with explicit NA levels generates all combinations - Custom separator with keep_empty - Single-level factors - Ordered input returns regular factor (not ordered)
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 11 edge-case tests for
fct_cross()covering scenarios not previously tested.Tests Added
exclude = NULL): NA levels are treated as regular levels in cross combinations (e.g., "NA:y"), and NA values are not introducedkeep_emptywith explicit NA levels: All combinations including "NA:NA" are generatedsep = "-"andsep = ""work correctly withkeep_emptyfct_cross()returns a regular factor (not ordered), even when input is orderedValidation
devtools::test(filter = "cross"): PASS 21 (10 pre-existing + 11 new, 0 failures)tests/testthat/test-cross.R(+47 lines)