test: add edge-case tests for fct_collapse() and fct_lump_lowfreq()#401
Closed
LeonidasZhak wants to merge 1 commit into
Closed
test: add edge-case tests for fct_collapse() and fct_lump_lowfreq()#401LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
- fct_collapse: test NA values preserved, unused levels collapsed, !!! splice - fct_lump_lowfreq: test unused levels, NA values preserved - Fix lifecycle snapshot wording for group_other deprecation
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds edge-case tests for two data-cleaning functions:
fct_collapse()andfct_lump_lowfreq().fct_collapse()testsNAobservations remainNAafter collapsing levels!!!splice works: Verifies dynamic dots / named list input via!!!fct_lump_lowfreq()testsNAobservations remainNAafter lumpingSnapshot fix
_snaps/collapse.mdfrom "is deprecated as of" to "was deprecated in" to match current lifecycle package.Validation
All 233 tests pass (14 new tests added).