Engine: Deletion of actor can bring to crash #1375

engine/includes/components/component.h

@@ -68,6 +68,7 @@ class ENGINE_EXPORT Component : public Object {
 
     bool hasTag(const TString &tag);
     bool hasTagByHash(uint32_t hash);
+    const std::vector<uint32_t> &tags() const;
 
     virtual void composeComponent();
 

engine/src/components/actor.cpp

@@ -67,8 +67,20 @@ Actor::Actor() :
 }
 
 Actor::~Actor() {
-    if(m_scene && m_scene->world()) {
-        m_scene->world()->graphUpdated();
+    if(m_scene) {
+        World *world = m_scene->world();
+        if(world) {
+            world->graphUpdated();
+        }
+
+        for(auto it : getChildren()) {
+            Component *component = dynamic_cast<Component *>(it);
+            if(component) {
+                for(uint32_t it : component->tags()) {
+                    m_scene->removeFromGroupByHash(component, it);
+                }
+            }
+        }
     }
 }
 /*!

engine/src/components/component.cpp

@@ -188,6 +188,12 @@ bool Component::hasTag(const TString &tag) {
 bool Component::hasTagByHash(uint32_t hash) {
     return std::find(m_tags.begin(), m_tags.end(), hash) != m_tags.end();
 }
+/*!
+    Returns list of component tags.
+*/
+const std::vector<uint32_t> &Component::tags() const {
+    return m_tags;
+}
 /*!
     \internal
 */

worldeditor/src/screens/scenecomposer/actions/deleteobjects.cpp

@@ -121,16 +121,16 @@ void DeleteObjects::redo() {
         }
     }
 
+    m_controller->clear();
+    m_controller->selectActors(list);
+
     for(auto it : m_objects) {
         Object *object = Engine::findObject(it);
         if(object) {
             delete object;
         }
     }
 
-    m_controller->clear();
-    m_controller->selectActors(list);
-
     for(auto it : scenes) {
         emit m_controller->sceneUpdated(it);
     }