Update home config#4
Merged
Merged
Conversation
- Add `rclone` to user packages. - Set `TESTING_FARM_WATCH_TICK=3` for a more responsive `testing-farm watch`. - Fix Firefox profile so it is not reset on every start: use a stable `default` profile with `configPath = ".mozilla/firefox"` and the username for the profile `name`/`path`. - Switch git `signing.format` to the correct value `openpgp` (was the invalid `opengpg`). - Rename `efmls-configs.setup` to `efmls-configs.languages` to match the upstream nixvim API. - Add a `run-op` wrapper that runs `op` under the `onepassword-cli` sg group with properly quoted arguments. - Update `claude-redhat` to use `CLOUD_ML_REGION=global` per the new Red Hat Vertex region policy. - Quote `\$HOME` in the `tft-admin` wrapper's `poetry -C` path. - Autostart `blueman-applet` in Sway for the Bluetooth tray icon. Signed-off-by: Miroslav Vadkerti <[email protected]>
Reviewer's GuideHome-manager configuration update that tweaks Firefox profile handling, Git and testing-farm settings, adds small helper scripts and packages, and aligns editor/desktop configs with upstream and infra expectations. Flow diagram for the new run-op wrapper behaviorflowchart LR
A[user_runs_run-op] --> B[build_cmd_array_with_op_and_args]
B --> C[printf_quoted_cmd_with_percent_q]
C --> D[exec_sg_onepassword-cli_with_command]
D --> E[sg_executes_op_under_onepassword-cli_group]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
run-opwrapper’s argument quoting logic (cmd=(op "$@")plus theprintf -v quoted_cmd ' %q' "''${cmd[@]}") is quite tricky; consider simplifying it to a more conventional pattern likeprintf -v quoted_cmd ' %q' "${cmd[@]}"to avoid surprising leading quotes and make the behavior easier to reason about. - The
run-opwrapper assumes theonepassword-cligroup exists and thatsgis available; you may want to handle the absence of the group/tool more gracefully (e.g., with a clear error message) to make failures easier to diagnose on new or differently configured systems.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `run-op` wrapper’s argument quoting logic (`cmd=(op "$@")` plus the `printf -v quoted_cmd ' %q' "''${cmd[@]}"`) is quite tricky; consider simplifying it to a more conventional pattern like `printf -v quoted_cmd ' %q' "${cmd[@]}"` to avoid surprising leading quotes and make the behavior easier to reason about.
- The `run-op` wrapper assumes the `onepassword-cli` group exists and that `sg` is available; you may want to handle the absence of the group/tool more gracefully (e.g., with a clear error message) to make failures easier to diagnose on new or differently configured systems.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rcloneto user packages.TESTING_FARM_WATCH_TICK=3for a more responsivetesting-farm watch.defaultprofile withconfigPath = ".mozilla/firefox"and the username for the profilename/path.signing.formatto the correct valueopenpgp(was the invalidopengpg).efmls-configs.setuptoefmls-configs.languagesto match the upstream nixvim API.run-opwrapper that runsopunder theonepassword-clisg group with properly quoted arguments.claude-redhatto useCLOUD_ML_REGION=globalper the new Red Hat Vertex region policy.$HOMEin thetft-adminwrapper'spoetry -Cpath.blueman-appletin Sway for the Bluetooth tray icon.Assisted-by: Claude Code
Summary by Sourcery
Update home configuration, shell wrappers, and editor settings to improve tooling, Firefox profile handling, and desktop usability.
New Features:
Bug Fixes:
Enhancements: