Skip to content

Update home config#4

Merged
thrix merged 1 commit into
mainfrom
update-home-config-2026-05
May 24, 2026
Merged

Update home config#4
thrix merged 1 commit into
mainfrom
update-home-config-2026-05

Conversation

@thrix-bot

@thrix-bot thrix-bot commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add rclone to user packages.
  • Set TESTING_FARM_WATCH_TICK=3 for a more responsive testing-farm watch.
  • Fix Firefox profile so it is not reset on every start: use a stable default profile with configPath = ".mozilla/firefox" and the username for the profile name/path.
  • Switch git signing.format to the correct value openpgp (was the invalid opengpg).
  • Rename efmls-configs.setup to efmls-configs.languages to match the upstream nixvim API.
  • Add a run-op wrapper that runs op under the onepassword-cli sg group with properly quoted arguments.
  • Update claude-redhat to use CLOUD_ML_REGION=global per the new Red Hat Vertex region policy.
  • Quote $HOME in the tft-admin wrapper's poetry -C path.
  • Autostart blueman-applet in Sway for the Bluetooth tray icon.

Assisted-by: Claude Code

Summary by Sourcery

Update home configuration, shell wrappers, and editor settings to improve tooling, Firefox profile handling, and desktop usability.

New Features:

  • Add rclone to the default user package set.
  • Add a run-op helper that runs the 1Password CLI under the appropriate system group.
  • Autostart the Blueman applet in Sway for a Bluetooth tray icon.

Bug Fixes:

  • Stabilize the Firefox profile configuration so it is not recreated on every launch.
  • Correct git signing configuration to use the valid openpgp format.
  • Ensure the tft-admin wrapper handles HOME paths safely by quoting them.

Enhancements:

  • Make testing-farm watch more responsive by tightening the watch tick interval.
  • Align the claude-redhat wrapper with the new global Vertex Cloud ML region policy.
  • Update the efmls-configs plugin config to use the new languages key matching upstream.

- Add `rclone` to user packages.
- Set `TESTING_FARM_WATCH_TICK=3` for a more responsive `testing-farm watch`.
- Fix Firefox profile so it is not reset on every start: use a stable
  `default` profile with `configPath = ".mozilla/firefox"` and the
  username for the profile `name`/`path`.
- Switch git `signing.format` to the correct value `openpgp` (was the
  invalid `opengpg`).
- Rename `efmls-configs.setup` to `efmls-configs.languages` to match the
  upstream nixvim API.
- Add a `run-op` wrapper that runs `op` under the `onepassword-cli` sg
  group with properly quoted arguments.
- Update `claude-redhat` to use `CLOUD_ML_REGION=global` per the new Red
  Hat Vertex region policy.
- Quote `\$HOME` in the `tft-admin` wrapper's `poetry -C` path.
- Autostart `blueman-applet` in Sway for the Bluetooth tray icon.

Signed-off-by: Miroslav Vadkerti <[email protected]>
@sourcery-ai

sourcery-ai Bot commented May 22, 2026

Copy link
Copy Markdown

Reviewer's Guide

Home-manager configuration update that tweaks Firefox profile handling, Git and testing-farm settings, adds small helper scripts and packages, and aligns editor/desktop configs with upstream and infra expectations.

Flow diagram for the new run-op wrapper behavior

flowchart LR
  A[user_runs_run-op] --> B[build_cmd_array_with_op_and_args]
  B --> C[printf_quoted_cmd_with_percent_q]
  C --> D[exec_sg_onepassword-cli_with_command]
  D --> E[sg_executes_op_under_onepassword-cli_group]
Loading

File-Level Changes

Change Details Files
Expand home-manager user environment and Firefox configuration for stability and usability.
  • Add rclone to the user packages list for backup/sync workflows
  • Set TESTING_FARM_WATCH_TICK to 3 in the environment to make testing-farm watch polling more responsive
  • Configure Firefox with an explicit configPath under .mozilla/firefox
  • Replace the previous named Firefox profile with a stable default profile whose name/path are derived from the username to avoid profile recreation on each start
  • Set git signing.format to the valid openpgp value under git.extraConfig
home.nix
Introduce and refine helper shell wrappers for container, secrets, and tooling CLIs.
  • Add a run-op Bash wrapper that builds a quoted op command array and executes it via sg onepassword-cli with exec
  • Update the claude-redhat wrapper to set CLOUD_ML_REGION=global instead of a fixed us-east5 region
  • Quote the $HOME path in the tft-admin wrapper’s poetry -C argument to handle spaces safely
pkgs/custom.nix
Adjust Sway and Neovim/nixvim configuration to improve desktop UX and follow upstream plugin API changes.
  • Add blueman-applet to Sway startup commands with always=true so the Bluetooth tray icon is present in the session
  • Rename the efmls-configs.setup attribute to efmls-configs.languages in the nixvim plugin configuration to match the upstream API
sway/config.nix
nixvim/plugins.nix

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The run-op wrapper’s argument quoting logic (cmd=(op "$@") plus the printf -v quoted_cmd ' %q' "''${cmd[@]}") is quite tricky; consider simplifying it to a more conventional pattern like printf -v quoted_cmd ' %q' "${cmd[@]}" to avoid surprising leading quotes and make the behavior easier to reason about.
  • The run-op wrapper assumes the onepassword-cli group exists and that sg is available; you may want to handle the absence of the group/tool more gracefully (e.g., with a clear error message) to make failures easier to diagnose on new or differently configured systems.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `run-op` wrapper’s argument quoting logic (`cmd=(op "$@")` plus the `printf -v quoted_cmd ' %q' "''${cmd[@]}"`) is quite tricky; consider simplifying it to a more conventional pattern like `printf -v quoted_cmd ' %q' "${cmd[@]}"` to avoid surprising leading quotes and make the behavior easier to reason about.
- The `run-op` wrapper assumes the `onepassword-cli` group exists and that `sg` is available; you may want to handle the absence of the group/tool more gracefully (e.g., with a clear error message) to make failures easier to diagnose on new or differently configured systems.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@thrix thrix merged commit ed2da17 into main May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants