Skip to content

Add non-interrupting active fork mode#1

Open
tkersey wants to merge 14 commits into
mainfrom
noninterrupting-active-fork
Open

Add non-interrupting active fork mode#1
tkersey wants to merge 14 commits into
mainfrom
noninterrupting-active-fork

Conversation

@tkersey

@tkersey tkersey commented Jun 27, 2026

Copy link
Copy Markdown

Summary

  • Add experimental activeForkMode for thread/fork, with nonInterrupting selecting the latest source-owned sampling boundary.
  • Persist sampling-boundary rollout markers before model sampling and fail closed when an active source has no stable boundary.
  • Keep omitted mode on legacy interrupted behavior, update docs/schema, and add focused core/app-server coverage.
  • Preserve explicit nullable serialization for omitted activeForkMode in v2 Rust payloads.

Proof

  • PATH=/opt/homebrew/Cellar/rustup/1.29.0_2/bin:$PATH just write-app-server-schema: pass
  • PATH=/opt/homebrew/Cellar/rustup/1.29.0_2/bin:$PATH just fmt: pass
  • PATH=/opt/homebrew/Cellar/rustup/1.29.0_2/bin:$PATH just test -p codex-app-server-protocol: pass, 251/251
  • PATH=/opt/homebrew/Cellar/rustup/1.29.0_2/bin:$PATH just test -p codex-app-server thread_fork_non_interrupting_replays_token_usage_from_selected_history: pass
  • PATH=/opt/homebrew/Cellar/rustup/1.29.0_2/bin:$PATH just fix -p codex-app-server-protocol: pass
  • CAS review against origin/main: clean, 0 findings, review thread 019f0ad7-68b3-76b2-aa13-024eb0c9289b
  • GitHub review threads: 5/5 resolved

Scope

  • branch: noninterrupting-active-fork
  • head: ab6b4ffd372e4cd104cb95515e49efcbe62759f3
  • base: main at d2885dc3cdbaf98a60e7256ec3e7dfdf2381041d

Readiness

  • PR mode: not closure-clean yet
  • Reason: local proof and CAS review are clean on the current head.
  • Caveats: hosted blocking-ci is still failing or pending on this fork; observed failures include missing codex-runners runner group jobs and macOS Bazel webrtc-sys build-script failures.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad04114660

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/thread_manager.rs Outdated
Comment thread codex-rs/core/src/thread_rollout_truncation.rs Outdated
Comment thread codex-rs/core/src/thread_manager.rs Outdated
Comment thread codex-rs/app-server/src/request_processors/thread_processor.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51683f69bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs Outdated
@tkersey tkersey force-pushed the noninterrupting-active-fork branch from ab6b4ff to 64bd05b Compare June 28, 2026 01:31
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant