Preserve profanity scanner check fast path#145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfanityScanHintsaligned with shared text hints while keeping every hint optional.scanner.check()whentextLength: 0is provided.Validation
npm ciwith a temporary npm cachenpm run checkwith a temporary npm cachenpm run benchmark:profanitywith a temporary npm cacheBenchmark Evidence
Baseline
origin/main:This branch:
The runtime change adds a hinted empty-input guard for package-owned scanner checks; scanner matching behavior and dictionary contents are unchanged.
Compatibility Notes
ProfanityScanInput.hintsremains optional, and existingtextLength/hasNonAsciicallers remain compatible.Closes #143
BEGIN_COMMIT_OVERRIDE
fix: preserve profanity scanner check fast path
END_COMMIT_OVERRIDE