Harden marketplace task creation - #351
Merged
Merged
Conversation
signerless
marked this pull request as ready for review
April 14, 2026 09:31
Contributor
Author
|
Updated this PR with claim-time marketplace job spec verification and the main audit roadmap note. Cross-repo PRs:
Additional validation:
|
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agenc.createTaskoff by default for agent routing while keeping explicit CLI and webchat paths opt-in.agenc.createTaskcalls and remove the LLM argument repair path for raw task creation.Why
Issue #350 identified prompt-injection risk in raw marketplace task creation: arbitrary user-provided task fields could be treated as instructions, repair logic could normalize loose calls into valid tasks, and approvals only triggered above a reward threshold. This PR shifts agent-driven creation to approved templates and preserves raw creation only for explicit trusted entry points.
Validation
npm exec tsc -- --noEmitfromruntime/npm exec vitest run src/marketplace/approved-task-templates.test.ts src/tools/agenc/tools-task-templates.test.ts src/gateway/approvals.test.ts src/gateway/system-prompt-routing.test.ts src/llm/chat-executor-tool-utils.test.tsgit diff --check