Skip to content

add diagram showing system overview#166

Open
patrickdemers6 wants to merge 1 commit into
mainfrom
architecture-diagram
Open

add diagram showing system overview#166
patrickdemers6 wants to merge 1 commit into
mainfrom
architecture-diagram

Conversation

@patrickdemers6

Copy link
Copy Markdown
Collaborator

Description

Adding a diagram which shows system architecture.

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

Comment thread doc/system_overview.txt
@ThomasAlxDmy

Copy link
Copy Markdown
Collaborator

Why are we documentating deprecated flow?

@patrickdemers6

Copy link
Copy Markdown
Collaborator Author

@ThomasAlxDmy this is the required flow at this point. This will be updated once the new flow is available.

Comment thread Makefile

.PHONY: test build vet linters install integration image-gen generate-protos generate-golang generate-python generate-ruby clean

doc-images:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be above PHONY and most likely needs to be part of PHONY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants