Support C++23 monadic operators in OptionalRef#210
Open
alexkaratarakis wants to merge 3 commits into
Open
Conversation
alexkaratarakis
changed the title
alexkaratarakis
force-pushed
the
optional_ref_monadic
branch
2 times, most recently
from
cdf5d14 to
7075713
Compare
alexkaratarakis
force-pushed
the
optional_ref_monadic
branch
from
7075713 to
f5a798e
Compare
Bobobalink
reviewed
Jan 23, 2026
| { | ||
| if (has_value()) | ||
| { | ||
| return std::invoke(std::forward<F>(func), *val()); |
Contributor
There was a problem hiding this comment.
Should this std::move val? Or will *val() already be an rvalue when we're inside this special kind of method
Comment on lines
+194
to
+196
| using InvokeResult = std::invoke_result_t<F, reference>; | ||
| static_assert(std::is_reference_v<InvokeResult>, | ||
| "transform() function must return a reference for OptionalReference"); |
Contributor
There was a problem hiding this comment.
I think having this requirement makes transform() pretty useless (how often does a real function return a reference?). I think returning a std::optional is much more reasonable here, at least as a valid choice. It could even intelligently choose between the two return types based on the function passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.